#141680: "incorrect score display"
Na kaj se nanaša prijava?
Kaj se je zgodilo? Prosimo, izberi spodaj
Kaj se je zgodilo? Prosimo, izberi spodaj
Prosimo preverite ali že obstaja poročilo o isti zadevi
Če je tako, GLASUJTE za to poročilo. Poročila z največ glasovi se obravnavajo PREDNOSTNO!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Natančen opis
-
• Kopirajte / prilepite sporočilo o napaki, ki ga vidite na zaslonu, če ga imate.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Prosim, pojasnite, kaj ste hoteli storiti, kaj ste naredili in kaj se je zgodilo
• Kateri brskalnik uporabljaš?
opera
-
• Kopirajte / prilepite besedilo, prikazano v angleščini, namesto v vašem jeziku. Če imate sliko zaslona te napake (dobra praksa), lahko uporabite Imgur.com za nalaganje in kopirate/prilepite povezavo do slike tukaj.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Je ta tekst dosegljiv v prevajalnem sistemu? Če ja, ali je bil preveden več kot 24 ur nazaj?
• Kateri brskalnik uporabljaš?
opera
-
• Natančno in jedrnato pojasnite svoj predlog, da bo čim lažje razumeti, kaj mislite.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kateri brskalnik uporabljaš?
opera
-
• Kaj je bilo prikazano na zaslonu, ko ste bili blokirani (prazen zaslon? Del vmesnika za igro? Sporočilo o napaki?)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kateri brskalnik uporabljaš?
opera
-
• Kateri del pravil ni bil upoštevan pri priredbi za BGA
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Je kršitev pravil vidna na seznamu potez? Če je, pri kateri številki poteze?
• Kateri brskalnik uporabljaš?
opera
-
• Katero potezo ste želeli narediti v igri?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Kaj ste poskušali narediti, da bi izvedli to potezo v igri?
-
• Kaj se je zgodilo, ko ste poskusili to storiti (sporočilo o napaki, sporočilo v vrstici stanja, ...)?
• Kateri brskalnik uporabljaš?
opera
-
• Na kateri točki v igri se je težava pojavila (katera navodila so bila prikazana)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Kaj se je zgodilo, ko ste poskušali narediti to potezo v igri (sporočilo o napaki, sporočilo v vrstici stanja, ...)?
• Kateri brskalnik uporabljaš?
opera
-
• Prosim opiši problem s prikazom. Če imate sliko zaslona te napake (dobra praksa), lahko uporabite Imgur.com za nalaganje in kopirate/prilepite povezavo do slike tukaj.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kateri brskalnik uporabljaš?
opera
-
• Kopirajte / prilepite besedilo, prikazano v angleščini, namesto v vašem jeziku. Če imate sliko zaslona te napake (dobra praksa), lahko uporabite Imgur.com za nalaganje in kopirate/prilepite povezavo do slike tukaj.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Je ta tekst dosegljiv v prevajalnem sistemu? Če ja, ali je bil preveden več kot 24 ur nazaj?
• Kateri brskalnik uporabljaš?
opera
-
• Natančno in jedrnato pojasnite svoj predlog, da bo čim lažje razumeti, kaj mislite.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kateri brskalnik uporabljaš?
opera
Zgodovina poročil
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Dodaj nekaj k temu poročilu
- Drug ID mize/ premikanje ID-ja
- Ali je F5 rešil težavo?
- Se je problem pojavil večkrat? Vsakič? Naključno?
- Če imate sliko zaslona te napake (dobra praksa), lahko uporabite Imgur.com za nalaganje in kopirate/prilepite povezavo do slike tukaj.
